Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NetworkClient.OwnedObjects always returning a count of zero #2631

Merged
merged 7 commits into from
Jul 20, 2023
Merged

fix: NetworkClient.OwnedObjects always returning a count of zero #2631

merged 7 commits into from
Jul 20, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

This PR resolves the issue where NetworkClient.OwnedObjects was not returning any owned objects due to the NetworkClient.IsConnected not being properly set.

fix: #2626

Changelog

  • Fixed: issue where NetworkClient.OwnedObjects was not returning any owned objects due to the NetworkClient.IsConnected not being properly set.

Testing and Documentation

  • Includes integration test in NetworkObjectOwnershipTests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
14499a3 
This fixes the issue with NetworkClient.OwnedObjects always returning a zero count.
@NoelStephensUnity
style
d2e4cc2 
removing TODO 2023-Q2 comments
@NoelStephensUnity
test
2c75405 
This validates the fixes for the owned objects list.
@NoelStephensUnity
update
ebb39e1 
removing an unrequired change.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner July 19, 2023 23:26
@NoelStephensUnity
update
ee980f9 
Adding the change log entry for this PR.
@NoelStephensUnity
test fix
919f069 
Only test host for spawned objects locally, ignore that one portion when testing server only pass.
@NoelStephensUnity
Merge branch 'develop' into fix/network-client-owned-objects
0a9bbd9
samlucas-unity
samlucas-unity approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@samlucas-unity samlucas-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@NoelStephensUnity NoelStephensUnity merged commit dfe7138 into develop Jul 20, 2023
1 check passed
@NoelStephensUnity NoelStephensUnity deleted the fix/network-client-owned-objects branch July 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlucas-unity samlucas-unity samlucas-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGO 1.5.1 OwnedObjects broken
2 participants
@NoelStephensUnity @samlucas-unity